summaryrefslogtreecommitdiffstats
path: root/drivers/iommu/omap-iommu.c
diff options
context:
space:
mode:
authorRobin Murphy2019-07-29 18:46:00 +0200
committerJoerg Roedel2019-08-09 17:31:39 +0200
commitab2cbeb0ed301a9f0460078e91b09f39958212ef (patch)
treef63defbae2945d3846f20b852ccde41b9208f1b3 /drivers/iommu/omap-iommu.c
parentiommu/vt-d: Correctly check format of page table in debugfs (diff)
downloadkernel-qcow2-linux-ab2cbeb0ed301a9f0460078e91b09f39958212ef.tar.gz
kernel-qcow2-linux-ab2cbeb0ed301a9f0460078e91b09f39958212ef.tar.xz
kernel-qcow2-linux-ab2cbeb0ed301a9f0460078e91b09f39958212ef.zip
iommu/dma: Handle SG length overflow better
Since scatterlist dimensions are all unsigned ints, in the relatively rare cases where a device's max_segment_size is set to UINT_MAX, then the "cur_len + s_length <= max_len" check in __finalise_sg() will always return true. As a result, the corner case of such a device mapping an excessively large scatterlist which is mergeable to or beyond a total length of 4GB can lead to overflow and a bogus truncated dma_length in the resulting segment. As we already assume that any single segment must be no longer than max_len to begin with, this can easily be addressed by reshuffling the comparison. Fixes: 809eac54cdd6 ("iommu/dma: Implement scatterlist segment merging") Reported-by: Nicolin Chen <nicoleotsuka@gmail.com> Tested-by: Nicolin Chen <nicoleotsuka@gmail.com> Signed-off-by: Robin Murphy <robin.murphy@arm.com> Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu/omap-iommu.c')
0 files changed, 0 insertions, 0 deletions