summaryrefslogtreecommitdiffstats
path: root/drivers/irqchip/irq-mtk-sysirq.c
diff options
context:
space:
mode:
authorMarc Zyngier2018-06-22 11:52:52 +0200
committerThomas Gleixner2018-06-22 14:22:01 +0200
commit83559b47cdc4d396fc1187a13b527d01b55e0fe6 (patch)
tree334c14cf25e94f001202cda8c3a6de3651b90ff5 /drivers/irqchip/irq-mtk-sysirq.c
parentirqchip/gic-v3-its: Don't bind LPI to unavailable NUMA node (diff)
downloadkernel-qcow2-linux-83559b47cdc4d396fc1187a13b527d01b55e0fe6.tar.gz
kernel-qcow2-linux-83559b47cdc4d396fc1187a13b527d01b55e0fe6.tar.xz
kernel-qcow2-linux-83559b47cdc4d396fc1187a13b527d01b55e0fe6.zip
irqchip/gic-v3-its: Only emit SYNC if targetting a valid collection
It is possible, under obscure circumstances, to convince the ITS driver to emit a SYNC operation that targets a collection that is not bound to any redistributor (and the target_address field is zero) because the corresponding CPU has not been seen yet (the system has been booted with max_cpus="something small"). If the ITS is using the linear CPU number as the target, this is not a big deal, as we just end-up issuing a SYNC to CPU0. But if the ITS requires the physical address of the redistributor (with GITS_TYPER.PTA==1), we end-up asking the ITS to write to the physical address zero, which is not exactly a good idea (there has been report of the ITS locking up). This should of course never happen, but hey, this is SW... In order to avoid the above disaster, let's track which collections have been actually initialized, and let's not generate a SYNC if the collection hasn't been properly bound to a redistributor. Take this opportunity to spit our a warning, in the hope that someone may report the issue if it arrises again. Reported-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: Sumit Garg <sumit.garg@linaro.org> Link: https://lkml.kernel.org/r/20180622095254.5906-6-marc.zyngier@arm.com
Diffstat (limited to 'drivers/irqchip/irq-mtk-sysirq.c')
0 files changed, 0 insertions, 0 deletions