diff options
| author | Heiner Litz | 2019-02-11 13:25:09 +0100 |
|---|---|---|
| committer | Jens Axboe | 2019-02-11 16:18:08 +0100 |
| commit | 0586942f03b71bc95b0ee356ff6b09d53acbad06 (patch) | |
| tree | 1bae68e44c9494ebe36106c7b8e8e0f65749222b /drivers/lightnvm/pblk.h | |
| parent | lightnvm: pblk: prevent stall due to wb threshold (diff) | |
| download | kernel-qcow2-linux-0586942f03b71bc95b0ee356ff6b09d53acbad06.tar.gz kernel-qcow2-linux-0586942f03b71bc95b0ee356ff6b09d53acbad06.tar.xz kernel-qcow2-linux-0586942f03b71bc95b0ee356ff6b09d53acbad06.zip | |
lightnvm: pblk: fix race condition on GC
This patch fixes a race condition where a write is mapped to the last
sectors of a line. The write is synced to the device but the L2P is not
updated yet. When the line is garbage collected before the L2P update
is performed, the sectors are ignored by the GC logic and the line is
freed before all sectors are moved. When the L2P is finally updated, it
contains a mapping to a freed line, subsequent reads of the
corresponding LBAs fail.
This patch introduces a per line counter specifying the number of
sectors that are synced to the device but have not been updated in the
L2P. Lines with a counter of greater than zero will not be selected
for GC.
Signed-off-by: Heiner Litz <hlitz@ucsc.edu>
Reviewed-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
Reviewed-by: Javier González <javier@javigon.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/lightnvm/pblk.h')
| -rw-r--r-- | drivers/lightnvm/pblk.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h index a6386d5acd73..ac3ab778e976 100644 --- a/drivers/lightnvm/pblk.h +++ b/drivers/lightnvm/pblk.h @@ -487,6 +487,7 @@ struct pblk_line { __le32 *vsc; /* Valid sector count in line */ struct kref ref; /* Write buffer L2P references */ + atomic_t sec_to_update; /* Outstanding L2P updates to ppa */ struct pblk_w_err_gc *w_err_gc; /* Write error gc recovery metadata */ |