diff options
| author | Jonathan Brassow | 2012-05-22 05:55:31 +0200 |
|---|---|---|
| committer | NeilBrown | 2012-05-22 05:55:31 +0200 |
| commit | c32fb9e7ecee25a5b6a45bf968dfef76f323e185 (patch) | |
| tree | 5de381a4d0c926c480d0e7244975a81450f8ecce /drivers/md | |
| parent | DM RAID: Record and handle missing devices (diff) | |
| download | kernel-qcow2-linux-c32fb9e7ecee25a5b6a45bf968dfef76f323e185.tar.gz kernel-qcow2-linux-c32fb9e7ecee25a5b6a45bf968dfef76f323e185.tar.xz kernel-qcow2-linux-c32fb9e7ecee25a5b6a45bf968dfef76f323e185.zip | |
DM RAID: Use md_error() in place of simply setting Faulty bit
When encountering an error while reading the superblock, call md_error.
We are currently setting the 'Faulty' bit on one of the array devices when an
error is encountered while reading the superblock of a dm-raid array. We should
be calling md_error(), as it handles the error more completely.
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/dm-raid.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index f1797c4f09c4..017c34d78d61 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -603,7 +603,7 @@ static int read_disk_sb(struct md_rdev *rdev, int size) if (!sync_page_io(rdev, 0, size, rdev->sb_page, READ, 1)) { DMERR("Failed to read superblock of device at position %d", rdev->raid_disk); - set_bit(Faulty, &rdev->flags); + md_error(rdev->mddev, rdev); return -EINVAL; } |