diff options
| author | Mauro Carvalho Chehab | 2011-07-09 23:57:54 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab | 2011-07-27 22:55:48 +0200 |
| commit | bcd2ebb76039bf4b1d1cb9f9f0e182548578e692 (patch) | |
| tree | 7fcd647e3f9f7ea420417bb36abd46e786911bba /drivers/media/dvb/frontends/drxk_hard.c | |
| parent | [media] drxk: Convert an #ifdef logic as a new config parameter (diff) | |
| download | kernel-qcow2-linux-bcd2ebb76039bf4b1d1cb9f9f0e182548578e692.tar.gz kernel-qcow2-linux-bcd2ebb76039bf4b1d1cb9f9f0e182548578e692.tar.xz kernel-qcow2-linux-bcd2ebb76039bf4b1d1cb9f9f0e182548578e692.zip | |
[media] drxk: Avoid OOPSes if firmware is corrupted
Don't read paste the buffer, if the firmware is corrupted.
Instead, print an error message.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/dvb/frontends/drxk_hard.c')
| -rw-r--r-- | drivers/media/dvb/frontends/drxk_hard.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c index c4b35a5638cd..89db37835872 100644 --- a/drivers/media/dvb/frontends/drxk_hard.c +++ b/drivers/media/dvb/frontends/drxk_hard.c @@ -1388,6 +1388,12 @@ static int DownloadMicrocode(struct drxk_state *state, BlockCRC = (pSrc[0] << 8) | pSrc[1]; pSrc += sizeof(u16); offset += sizeof(u16); + + if (offset + BlockSize > Length) { + printk(KERN_ERR "drxk: Firmware is corrupted.\n"); + return -EINVAL; + } + status = write_block(state, Address, BlockSize, pSrc); if (status < 0) break; |