summaryrefslogtreecommitdiffstats
path: root/drivers/media/i2c/cx25840
diff options
context:
space:
mode:
authorHans Verkuil2012-09-05 15:38:10 +0200
committerMauro Carvalho Chehab2012-10-01 22:12:51 +0200
commit30634e8e41d413b0084ba29f843361a1fd9fbdce (patch)
tree0712b67462e242c926502ff697beed75b6f078d6 /drivers/media/i2c/cx25840
parent[media] v4l2-ctrls: add a filter function to v4l2_ctrl_add_handler (diff)
downloadkernel-qcow2-linux-30634e8e41d413b0084ba29f843361a1fd9fbdce.tar.gz
kernel-qcow2-linux-30634e8e41d413b0084ba29f843361a1fd9fbdce.tar.xz
kernel-qcow2-linux-30634e8e41d413b0084ba29f843361a1fd9fbdce.zip
[media] sliced vbi: subdevs shouldn't clear the full v4l2_sliced_vbi_format struct
Various subdevs cleared the full v4l2_sliced_vbi_format struct, when only the service_set/lines fields should have been cleared. Due to this the io_size field was wrongly cleared to 0, causing a v4l2-compliance error. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/i2c/cx25840')
-rw-r--r--drivers/media/i2c/cx25840/cx25840-vbi.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/media/i2c/cx25840/cx25840-vbi.c b/drivers/media/i2c/cx25840/cx25840-vbi.c
index 64a4004f8a97..c39e91dc1137 100644
--- a/drivers/media/i2c/cx25840/cx25840-vbi.c
+++ b/drivers/media/i2c/cx25840/cx25840-vbi.c
@@ -96,7 +96,8 @@ int cx25840_g_sliced_fmt(struct v4l2_subdev *sd, struct v4l2_sliced_vbi_format *
int is_pal = !(state->std & V4L2_STD_525_60);
int i;
- memset(svbi, 0, sizeof(*svbi));
+ memset(svbi->service_lines, 0, sizeof(svbi->service_lines));
+ svbi->service_set = 0;
/* we're done if raw VBI is active */
if ((cx25840_read(client, 0x404) & 0x10) == 0)
return 0;