diff options
| author | Guennadi Liakhovetski | 2014-04-14 15:49:34 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab | 2014-05-14 00:58:08 +0200 |
| commit | 322e6d19ede96ac6c13a132590c435ff17e0827f (patch) | |
| tree | 15ad2435106c707c331aac3a8662e70830b4399e /drivers/media/i2c/ov7670.c | |
| parent | [media] soc_camera: disable STD ioctls if no tvnorms are set (diff) | |
| download | kernel-qcow2-linux-322e6d19ede96ac6c13a132590c435ff17e0827f.tar.gz kernel-qcow2-linux-322e6d19ede96ac6c13a132590c435ff17e0827f.tar.xz kernel-qcow2-linux-322e6d19ede96ac6c13a132590c435ff17e0827f.zip | |
[media] V4L2: ov7670: fix a wrong index, potentially Oopsing the kernel from user-space
Commit 75e2bdad8901a0b599e01a96229be922eef1e488 "ov7670: allow
configuration of image size, clock speed, and I/O method" uses a wrong
index to iterate an array. Apart from being wrong, it also uses an
unchecked value from user-space, which can cause access to unmapped
memory in the kernel, triggered by a normal desktop user with rights to
use V4L2 devices.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Jonathan Corbet <corbet@lwn.net>
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media/i2c/ov7670.c')
| -rw-r--r-- | drivers/media/i2c/ov7670.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index e8a1ce204036..cdd7c1b7259b 100644 --- a/drivers/media/i2c/ov7670.c +++ b/drivers/media/i2c/ov7670.c @@ -1109,7 +1109,7 @@ static int ov7670_enum_framesizes(struct v4l2_subdev *sd, * windows that fall outside that. */ for (i = 0; i < n_win_sizes; i++) { - struct ov7670_win_size *win = &info->devtype->win_sizes[index]; + struct ov7670_win_size *win = &info->devtype->win_sizes[i]; if (info->min_width && win->width < info->min_width) continue; if (info->min_height && win->height < info->min_height) |