summaryrefslogtreecommitdiffstats
path: root/drivers/media/i2c
diff options
context:
space:
mode:
authorChristophe JAILLET2018-05-08 08:14:15 +0200
committerMauro Carvalho Chehab2018-05-11 17:36:09 +0200
commit50a0efae2758687737349707e335ccf2de9007d2 (patch)
tree8c18439e13320500c4195fa3a6215ebb542ebb62 /drivers/media/i2c
parentmedia: saa7146: fix error return from master_xfer (diff)
downloadkernel-qcow2-linux-50a0efae2758687737349707e335ccf2de9007d2.tar.gz
kernel-qcow2-linux-50a0efae2758687737349707e335ccf2de9007d2.tar.xz
kernel-qcow2-linux-50a0efae2758687737349707e335ccf2de9007d2.zip
media: i2c: tda1997: Fix an error handling path 'tda1997x_probe()'
If 'media_entity_pads_init()' fails, we must free the resources allocated by 'v4l2_ctrl_handler_init()', as already done in the previous error handling path. 'goto' the right label to fix it. Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI receiver driver") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Hans Verkuil <hansverk@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/i2c')
-rw-r--r--drivers/media/i2c/tda1997x.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
index 1c5b5f70866f..b697c6f741d1 100644
--- a/drivers/media/i2c/tda1997x.c
+++ b/drivers/media/i2c/tda1997x.c
@@ -2721,7 +2721,7 @@ static int tda1997x_probe(struct i2c_client *client,
state->pads);
if (ret) {
v4l_err(client, "failed entity_init: %d", ret);
- goto err_free_mutex;
+ goto err_free_handler;
}
ret = v4l2_async_register_subdev(sd);