diff options
| author | Mauro Carvalho Chehab | 2015-04-28 14:50:36 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab | 2015-04-30 18:15:31 +0200 |
| commit | 2f9e682d05e27fef1a78b4089cfde818ea109d25 (patch) | |
| tree | 31a07b0109c3f06846fb1456928874fe4eccb8f1 /drivers/media/pci/cx18 | |
| parent | [media] rc: fix bad indenting (diff) | |
| download | kernel-qcow2-linux-2f9e682d05e27fef1a78b4089cfde818ea109d25.tar.gz kernel-qcow2-linux-2f9e682d05e27fef1a78b4089cfde818ea109d25.tar.xz kernel-qcow2-linux-2f9e682d05e27fef1a78b4089cfde818ea109d25.zip | |
[media] cx18: avoid going past input/audio array
As reported by smatch:
drivers/media/pci/cx18/cx18-driver.c:807 cx18_init_struct2() error: buffer overflow 'cx->card->video_inputs' 6 <= 6
That happens because nof_inputs and nof_audio_inputs can be initialized
as CX18_CARD_MAX_VIDEO_INPUTS, instead of CX18_CARD_MAX_VIDEO_INPUTS - 1.
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Acked-by: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/pci/cx18')
| -rw-r--r-- | drivers/media/pci/cx18/cx18-driver.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/pci/cx18/cx18-driver.c b/drivers/media/pci/cx18/cx18-driver.c index 83f5074706f9..260e462d91b4 100644 --- a/drivers/media/pci/cx18/cx18-driver.c +++ b/drivers/media/pci/cx18/cx18-driver.c @@ -786,11 +786,11 @@ static void cx18_init_struct2(struct cx18 *cx) { int i; - for (i = 0; i < CX18_CARD_MAX_VIDEO_INPUTS; i++) + for (i = 0; i < CX18_CARD_MAX_VIDEO_INPUTS - 1; i++) if (cx->card->video_inputs[i].video_type == 0) break; cx->nof_inputs = i; - for (i = 0; i < CX18_CARD_MAX_AUDIO_INPUTS; i++) + for (i = 0; i < CX18_CARD_MAX_AUDIO_INPUTS - 1; i++) if (cx->card->audio_inputs[i].audio_type == 0) break; cx->nof_audio_inputs = i; |