diff options
| author | Colin Ian King | 2017-09-05 17:19:44 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab | 2017-09-23 14:29:45 +0200 |
| commit | e90ce8aa3cb2fcfb0fd45f95e89946a15c03737c (patch) | |
| tree | 28a70026ec999173ca9c026d5d344f9f6126e528 /drivers/media/pci | |
| parent | media: cx25840: make array stds static const, reduces object code size (diff) | |
| download | kernel-qcow2-linux-e90ce8aa3cb2fcfb0fd45f95e89946a15c03737c.tar.gz kernel-qcow2-linux-e90ce8aa3cb2fcfb0fd45f95e89946a15c03737c.tar.xz kernel-qcow2-linux-e90ce8aa3cb2fcfb0fd45f95e89946a15c03737c.zip | |
media: cobalt: remove redundant zero check on retval
The error handling paths all end up with retval being non-zero,
so the check for retval being zero is always false and hence
is redundant. Remove it.
Detected by CoverityScan CID#1309479 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/pci')
| -rw-r--r-- | drivers/media/pci/cobalt/cobalt-driver.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/media/pci/cobalt/cobalt-driver.c b/drivers/media/pci/cobalt/cobalt-driver.c index 98b6cb9505d1..8487ecaa4d30 100644 --- a/drivers/media/pci/cobalt/cobalt-driver.c +++ b/drivers/media/pci/cobalt/cobalt-driver.c @@ -767,8 +767,6 @@ err_pci: err_wq: destroy_workqueue(cobalt->irq_work_queues); err: - if (retval == 0) - retval = -ENODEV; cobalt_err("error %d on initialization\n", retval); v4l2_device_unregister(&cobalt->v4l2_dev); |