summaryrefslogtreecommitdiffstats
path: root/drivers/media/platform/davinci
diff options
context:
space:
mode:
authorStanimir Varbanov2017-07-19 13:51:37 +0200
committerMauro Carvalho Chehab2017-07-20 21:55:14 +0200
commita6e2d36bf6b7e2f821ce89dc6e5fb9b4dfe2970c (patch)
tree5c18121d5aba9a8c8595c785e2e469eb64e29e6d /drivers/media/platform/davinci
parentmedia: venus: hfi: fix error handling in hfi_sys_init_done() (diff)
downloadkernel-qcow2-linux-a6e2d36bf6b7e2f821ce89dc6e5fb9b4dfe2970c.tar.gz
kernel-qcow2-linux-a6e2d36bf6b7e2f821ce89dc6e5fb9b4dfe2970c.tar.xz
kernel-qcow2-linux-a6e2d36bf6b7e2f821ce89dc6e5fb9b4dfe2970c.zip
media: venus: don't abuse dma_alloc for non-DMA allocations
In venus_boot(), we pass a pointer to a phys_addr_t into dmam_alloc_coherent, which the compiler warns about: platform/qcom/venus/firmware.c: In function 'venus_boot': platform/qcom/venus/firmware.c:63:49: error: passing argument 3 of 'dmam_alloc_coherent' from incompatible pointer type [-Werror=incompatible-pointer-types] To avoid the error refactor venus_boot function by discard dma_alloc_coherent invocation because we don't want to map the memory for the device. Something more, the usage of DMA mapping API is actually wrong and the current implementation relies on several bugs in DMA mapping code. When these bugs are fixed that will break firmware loading, so fix this now to avoid future troubles. The meaning of venus_boot is to copy the content of the firmware buffer into reserved (and memblock removed) block of memory and pass that physical address to the trusted zone for authentication and mapping through iommu form the secure world. After iommu mapping is done the iova is passed as ane entry point to the remote processor. After this change memory-region property is parsed manually and the physical address is memremap to CPU, call mdt_load to load firmware segments into proper places and unmap reserved memory. Fixes: af2c3834c8ca ("[media] media: venus: adding core part and helper functions") Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> Reviewed-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/platform/davinci')
0 files changed, 0 insertions, 0 deletions