summaryrefslogtreecommitdiffstats
path: root/drivers/media/platform/s5p-fimc/fimc-lite-reg.c
diff options
context:
space:
mode:
authorSylwester Nawrocki2012-07-26 12:13:08 +0200
committerMauro Carvalho Chehab2012-10-01 19:55:46 +0200
commit1bcd7041947287206065af584e15fc4f41113da7 (patch)
tree58483b0d18370ab7487684b2ffb9852bc9dd191c /drivers/media/platform/s5p-fimc/fimc-lite-reg.c
parent[media] s5p-fimc: Enable FIMC-LITE driver only for SOC_EXYNOS4x12 (diff)
downloadkernel-qcow2-linux-1bcd7041947287206065af584e15fc4f41113da7.tar.gz
kernel-qcow2-linux-1bcd7041947287206065af584e15fc4f41113da7.tar.xz
kernel-qcow2-linux-1bcd7041947287206065af584e15fc4f41113da7.zip
[media] s5p-fimc: Don't allocate fimc-lite video device structure dynamically
This fixes potential invalid pointer de-reference, when media_entity_cleanup() is called after video_unregister_device, and video device structure memory is already freed. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/platform/s5p-fimc/fimc-lite-reg.c')
-rw-r--r--drivers/media/platform/s5p-fimc/fimc-lite-reg.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/s5p-fimc/fimc-lite-reg.c b/drivers/media/platform/s5p-fimc/fimc-lite-reg.c
index f996e94873f6..09dc71e477df 100644
--- a/drivers/media/platform/s5p-fimc/fimc-lite-reg.c
+++ b/drivers/media/platform/s5p-fimc/fimc-lite-reg.c
@@ -137,7 +137,7 @@ void flite_hw_set_source_format(struct fimc_lite *dev, struct flite_frame *f)
}
if (i == 0 && src_pixfmt_map[i][0] != pixelcode) {
- v4l2_err(dev->vfd,
+ v4l2_err(&dev->vfd,
"Unsupported pixel code, falling back to %#08x\n",
src_pixfmt_map[i][0]);
}