diff options
| author | Sylwester Nawrocki | 2012-07-26 12:13:08 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab | 2012-10-01 19:55:46 +0200 |
| commit | 1bcd7041947287206065af584e15fc4f41113da7 (patch) | |
| tree | 58483b0d18370ab7487684b2ffb9852bc9dd191c /drivers/media/platform/s5p-fimc/fimc-mdevice.c | |
| parent | [media] s5p-fimc: Enable FIMC-LITE driver only for SOC_EXYNOS4x12 (diff) | |
| download | kernel-qcow2-linux-1bcd7041947287206065af584e15fc4f41113da7.tar.gz kernel-qcow2-linux-1bcd7041947287206065af584e15fc4f41113da7.tar.xz kernel-qcow2-linux-1bcd7041947287206065af584e15fc4f41113da7.zip | |
[media] s5p-fimc: Don't allocate fimc-lite video device structure dynamically
This fixes potential invalid pointer de-reference, when
media_entity_cleanup() is called after video_unregister_device,
and video device structure memory is already freed.
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/platform/s5p-fimc/fimc-mdevice.c')
| -rw-r--r-- | drivers/media/platform/s5p-fimc/fimc-mdevice.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/s5p-fimc/fimc-mdevice.c b/drivers/media/platform/s5p-fimc/fimc-mdevice.c index e65bb283fd8a..0dd26b69232c 100644 --- a/drivers/media/platform/s5p-fimc/fimc-mdevice.c +++ b/drivers/media/platform/s5p-fimc/fimc-mdevice.c @@ -591,7 +591,7 @@ static int __fimc_md_create_flite_source_links(struct fimc_md *fmd) if (fimc == NULL) continue; source = &fimc->subdev.entity; - sink = &fimc->vfd->entity; + sink = &fimc->vfd.entity; /* FIMC-LITE's subdev and video node */ ret = media_entity_create_link(source, FIMC_SD_PAD_SOURCE, sink, 0, flags); |