diff options
| author | Markus Elfring | 2015-11-05 19:23:50 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab | 2015-11-19 13:10:22 +0100 |
| commit | 1ea7252d978637dca24f89c72dee887fe2bef689 (patch) | |
| tree | 82bc5e1fa5e2f6ce89ceb429bab10e6b6a0ab88c /drivers/media/platform/sti | |
| parent | [media] c8sectpfe: Delete unnecessary checks before two function calls (diff) | |
| download | kernel-qcow2-linux-1ea7252d978637dca24f89c72dee887fe2bef689.tar.gz kernel-qcow2-linux-1ea7252d978637dca24f89c72dee887fe2bef689.tar.xz kernel-qcow2-linux-1ea7252d978637dca24f89c72dee887fe2bef689.zip | |
[media] c8sectpfe: Combine three checks into a single if block
The variable "tsin" was checked three times in a loop iteration of the
c8sectpfe_tuner_unregister_frontend() function.
This implementation detail could be improved by the combination of the
involved statements into a single if block so that this variable will be
checked only once there.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/platform/sti')
| -rw-r--r-- | drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c index 07fd6d9ee53a..2dfbe8ab5214 100644 --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c @@ -209,17 +209,18 @@ void c8sectpfe_tuner_unregister_frontend(struct c8sectpfe *c8sectpfe, tsin = fei->channel_data[n]; - if (tsin && tsin->frontend) { - dvb_unregister_frontend(tsin->frontend); - dvb_frontend_detach(tsin->frontend); - } + if (tsin) { + if (tsin->frontend) { + dvb_unregister_frontend(tsin->frontend); + dvb_frontend_detach(tsin->frontend); + } - if (tsin) i2c_put_adapter(tsin->i2c_adapter); - if (tsin && tsin->i2c_client) { - module_put(tsin->i2c_client->dev.driver->owner); - i2c_unregister_device(tsin->i2c_client); + if (tsin->i2c_client) { + module_put(tsin->i2c_client->dev.driver->owner); + i2c_unregister_device(tsin->i2c_client); + } } } |