summaryrefslogtreecommitdiffstats
path: root/drivers/media/tuners/tda18271-maps.c
diff options
context:
space:
mode:
authorEzequiel Garcia2012-10-23 20:57:17 +0200
committerMauro Carvalho Chehab2012-12-27 22:01:13 +0100
commit7f05b24536f068c0a5072929fb6c0fb2099d273c (patch)
tree1ec1c8a1151b7de2b23611056299cfa16b8452f2 /drivers/media/tuners/tda18271-maps.c
parent[media] tuners/xc2028: Replace memcpy with struct assignment (diff)
downloadkernel-qcow2-linux-7f05b24536f068c0a5072929fb6c0fb2099d273c.tar.gz
kernel-qcow2-linux-7f05b24536f068c0a5072929fb6c0fb2099d273c.tar.xz
kernel-qcow2-linux-7f05b24536f068c0a5072929fb6c0fb2099d273c.zip
[media] tuners/tda18271: Replace memcpy with struct assignment
This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/tuners/tda18271-maps.c')
-rw-r--r--drivers/media/tuners/tda18271-maps.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/media/tuners/tda18271-maps.c b/drivers/media/tuners/tda18271-maps.c
index fb881c667c94..b62e925f643f 100644
--- a/drivers/media/tuners/tda18271-maps.c
+++ b/drivers/media/tuners/tda18271-maps.c
@@ -1290,13 +1290,11 @@ int tda18271_assign_map_layout(struct dvb_frontend *fe)
switch (priv->id) {
case TDA18271HDC1:
priv->maps = &tda18271c1_map_layout;
- memcpy(&priv->std, &tda18271c1_std_map,
- sizeof(struct tda18271_std_map));
+ priv->std = tda18271c1_std_map;
break;
case TDA18271HDC2:
priv->maps = &tda18271c2_map_layout;
- memcpy(&priv->std, &tda18271c2_std_map,
- sizeof(struct tda18271_std_map));
+ priv->std = tda18271c2_std_map;
break;
default:
ret = -EINVAL;