diff options
| author | Ezequiel Garcia | 2012-10-23 20:57:16 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab | 2012-12-27 22:00:50 +0100 |
| commit | 03c420010f4c5ded38bd0fc909ccadc25c82d080 (patch) | |
| tree | c306653eb36225ba8d2b09e05f180d67f4784f64 /drivers/media/tuners/tuner-xc2028.c | |
| parent | [media] tuners/xc4000: Replace memcpy with struct assignment (diff) | |
| download | kernel-qcow2-linux-03c420010f4c5ded38bd0fc909ccadc25c82d080.tar.gz kernel-qcow2-linux-03c420010f4c5ded38bd0fc909ccadc25c82d080.tar.xz kernel-qcow2-linux-03c420010f4c5ded38bd0fc909ccadc25c82d080.zip | |
[media] tuners/xc2028: Replace memcpy with struct assignment
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/tuners/tuner-xc2028.c')
| -rw-r--r-- | drivers/media/tuners/tuner-xc2028.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/tuners/tuner-xc2028.c b/drivers/media/tuners/tuner-xc2028.c index 7bcb6b0ff1df..09451737c77e 100644 --- a/drivers/media/tuners/tuner-xc2028.c +++ b/drivers/media/tuners/tuner-xc2028.c @@ -870,7 +870,7 @@ check_device: } read_not_reliable: - memcpy(&priv->cur_fw, &new_fw, sizeof(priv->cur_fw)); + priv->cur_fw = new_fw; /* * By setting BASE in cur_fw.type only after successfully loading all |