diff options
| author | Mauro Carvalho Chehab | 2014-03-14 18:29:06 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab | 2014-03-15 00:26:59 +0100 |
| commit | ed97a6fe5308e5982d118a25f0697b791af5ec50 (patch) | |
| tree | 3aefde16fcc9edf3c402347fab583eceb1aae44b /drivers/media/usb/dvb-usb-v2/af9035.h | |
| parent | [media] af9035: use af9033 PID filters (diff) | |
| download | kernel-qcow2-linux-ed97a6fe5308e5982d118a25f0697b791af5ec50.tar.gz kernel-qcow2-linux-ed97a6fe5308e5982d118a25f0697b791af5ec50.tar.xz kernel-qcow2-linux-ed97a6fe5308e5982d118a25f0697b791af5ec50.zip | |
[media] af9033: Don't export functions for the hardware filter
Exporting functions for hardware filter is a bad idea, as it
breaks compilation if:
CONFIG_DVB_USB_AF9035=y
CONFIG_DVB_AF9033=m
Because the PID filter function calls would be hardcoded at
af9035.
The same doesn't happen with af9033_attach() because the
dvb_attach() doesn't hardcode it. Instead, it dynamically
links it at runtime.
However, calling dvb_attach() multiple times is problematic,
as it increments module kref.
So, the better is to pass one parameter for the af9033 module
to fill the hardware filters, and then use it inside af9035.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media/usb/dvb-usb-v2/af9035.h')
| -rw-r--r-- | drivers/media/usb/dvb-usb-v2/af9035.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/usb/dvb-usb-v2/af9035.h b/drivers/media/usb/dvb-usb-v2/af9035.h index a1c68d829b8c..c21902fdd4c4 100644 --- a/drivers/media/usb/dvb-usb-v2/af9035.h +++ b/drivers/media/usb/dvb-usb-v2/af9035.h @@ -62,6 +62,8 @@ struct state { u8 dual_mode:1; u16 eeprom_addr; struct af9033_config af9033_config[2]; + + struct af9033_ops ops; }; static const u32 clock_lut_af9035[] = { |