diff options
| author | Mauro Carvalho Chehab | 2018-03-09 13:21:45 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab | 2018-05-04 17:00:54 +0200 |
| commit | 509f89652f83e834b3ef7a083e2eeac812b055f0 (patch) | |
| tree | cdf3b81862ebb63c36eba425dd14b4996b5e5cd7 /drivers/media/usb/em28xx | |
| parent | media: v4l2-core: get rid of videobuf-dvb (diff) | |
| download | kernel-qcow2-linux-509f89652f83e834b3ef7a083e2eeac812b055f0.tar.gz kernel-qcow2-linux-509f89652f83e834b3ef7a083e2eeac812b055f0.tar.xz kernel-qcow2-linux-509f89652f83e834b3ef7a083e2eeac812b055f0.zip | |
media: em28xx: fix a regression with HVR-950
Commit be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD second tuner
functionality") removed the logic with sets the alternate for the DVB
device. Without setting the right alternate, the device won't be
able to submit URBs, and userspace fails with -EMSGSIZE:
ERROR DMX_SET_PES_FILTER failed (PID = 0x2000): 90 Message too long
Tested with Hauppauge HVR-950 model A1C0.
Fixes: be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD second tuner functionality")
Cc: Brad Love <brad@nextdimension.cc>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/usb/em28xx')
| -rw-r--r-- | drivers/media/usb/em28xx/em28xx-dvb.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c index a54cb8dc52c9..2ce7de1c7cce 100644 --- a/drivers/media/usb/em28xx/em28xx-dvb.c +++ b/drivers/media/usb/em28xx/em28xx-dvb.c @@ -199,6 +199,7 @@ static int em28xx_start_streaming(struct em28xx_dvb *dvb) int rc; struct em28xx_i2c_bus *i2c_bus = dvb->adapter.priv; struct em28xx *dev = i2c_bus->dev; + struct usb_device *udev = interface_to_usbdev(dev->intf); int dvb_max_packet_size, packet_multiplier, dvb_alt; if (dev->dvb_xfer_bulk) { @@ -217,6 +218,7 @@ static int em28xx_start_streaming(struct em28xx_dvb *dvb) dvb_alt = dev->dvb_alt_isoc; } + usb_set_interface(udev, dev->ifnum, dvb_alt); rc = em28xx_set_mode(dev, EM28XX_DIGITAL_MODE); if (rc < 0) return rc; |