diff options
| author | Pan Bian | 2017-04-23 11:26:45 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab | 2017-06-06 12:28:36 +0200 |
| commit | 13174c388a76005c1abe454e47a37cd57edd8c8d (patch) | |
| tree | bc00553242f1e97190bc4627c93596e45f2152a9 /drivers/media/usb/gspca | |
| parent | [media] mxl111sf: Fix driver to use heap allocate buffers for USB messages (diff) | |
| download | kernel-qcow2-linux-13174c388a76005c1abe454e47a37cd57edd8c8d.tar.gz kernel-qcow2-linux-13174c388a76005c1abe454e47a37cd57edd8c8d.tar.xz kernel-qcow2-linux-13174c388a76005c1abe454e47a37cd57edd8c8d.zip | |
[media] m5602_s5k83a: check return value of kthread_create
Function kthread_create() returns an ERR_PTR on error. However, in
function s5k83a_start(), its return value is used without validation.
This may result in a bad memory access bug. This patch fixes the bug.
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/usb/gspca')
| -rw-r--r-- | drivers/media/usb/gspca/m5602/m5602_s5k83a.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c index be5e25d1a2e8..6ad8d4849680 100644 --- a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c +++ b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c @@ -345,6 +345,11 @@ int s5k83a_start(struct sd *sd) to assume that there is no better way of accomplishing this */ sd->rotation_thread = kthread_create(rotation_thread_function, sd, "rotation thread"); + if (IS_ERR(sd->rotation_thread)) { + err = PTR_ERR(sd->rotation_thread); + sd->rotation_thread = NULL; + return err; + } wake_up_process(sd->rotation_thread); /* Preinit the sensor */ |