summaryrefslogtreecommitdiffstats
path: root/drivers/media/usb/s2255
diff options
context:
space:
mode:
authorMauro Carvalho Chehab2017-05-19 14:05:19 +0200
committerMauro Carvalho Chehab2017-05-19 14:05:19 +0200
commitec33fbd585f76b0803a90ee66804fa6f937dccaa (patch)
treed135793ee2c538bde635f65dbceb16fb55a62a6d /drivers/media/usb/s2255
parent[media] soc_camera: annotate a switch fall through (diff)
downloadkernel-qcow2-linux-ec33fbd585f76b0803a90ee66804fa6f937dccaa.tar.gz
kernel-qcow2-linux-ec33fbd585f76b0803a90ee66804fa6f937dccaa.tar.xz
kernel-qcow2-linux-ec33fbd585f76b0803a90ee66804fa6f937dccaa.zip
[media] s2255drv: avoid a switch fall through
On this driver, it can fall through a switch. I tried to annotate it, in order to shut up a gcc warning, but that didn't work, as the logic there is somewhat complex. So, instead, let's just repeat the code. gcc should likely optimize it anyway, and this makes the code better readable, IMHO. Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/usb/s2255')
-rw-r--r--drivers/media/usb/s2255/s2255drv.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c
index a9d4484f7626..6a88b1dbb3a0 100644
--- a/drivers/media/usb/s2255/s2255drv.c
+++ b/drivers/media/usb/s2255/s2255drv.c
@@ -1803,6 +1803,8 @@ static int save_frame(struct s2255_dev *dev, struct s2255_pipeinfo *pipe_info)
default:
pr_info("s2255 unknown resp\n");
}
+ pdata++;
+ break;
default:
pdata++;
break;