diff options
| author | Adrian Bunk | 2008-09-03 22:12:25 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab | 2008-09-03 23:37:53 +0200 |
| commit | 8da9bae3292ea8aee803e7cda295877c361f0694 (patch) | |
| tree | b50317e39edf3f0d92e704bdfd87b0ea58f78fb1 /drivers/media/video | |
| parent | V4L/DVB (8840): dib0700: add basic support for Hauppauge Nova-TD-500 (84xxx) (diff) | |
| download | kernel-qcow2-linux-8da9bae3292ea8aee803e7cda295877c361f0694.tar.gz kernel-qcow2-linux-8da9bae3292ea8aee803e7cda295877c361f0694.tar.xz kernel-qcow2-linux-8da9bae3292ea8aee803e7cda295877c361f0694.zip | |
V4L/DVB (8842): vivi_release(): fix use-after-free
video_device_release() does kfree(), which made the following printk()
doing a use-after-free.
printk() first and release then.
Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video')
| -rw-r--r-- | drivers/media/video/vivi.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c index f55d77db1558..8ba8daafd7ea 100644 --- a/drivers/media/video/vivi.c +++ b/drivers/media/video/vivi.c @@ -1021,13 +1021,13 @@ static int vivi_release(void) dev = list_entry(list, struct vivi_dev, vivi_devlist); if (-1 != dev->vfd->minor) { - video_unregister_device(dev->vfd); - printk(KERN_INFO "%s: /dev/video%d unregistered.\n", + printk(KERN_INFO "%s: unregistering /dev/video%d\n", VIVI_MODULE_NAME, dev->vfd->minor); + video_unregister_device(dev->vfd); } else { - video_device_release(dev->vfd); - printk(KERN_INFO "%s: /dev/video%d released.\n", + printk(KERN_INFO "%s: releasing /dev/video%d\n", VIVI_MODULE_NAME, dev->vfd->minor); + video_device_release(dev->vfd); } kfree(dev); |