diff options
| author | Lee Jones | 2013-07-19 09:53:24 +0200 |
|---|---|---|
| committer | Lee Jones | 2013-09-02 11:22:44 +0200 |
| commit | d551c4c43ccac3ef272e10ac23a64eaac16c23fd (patch) | |
| tree | 672cee75a978ac9ead4860b278d8d0cb2ccaae76 /drivers/mfd | |
| parent | mfd: ab8500-debugfs: Apply a check for -ENOMEM after allocating memory for sysfs (diff) | |
| download | kernel-qcow2-linux-d551c4c43ccac3ef272e10ac23a64eaac16c23fd.tar.gz kernel-qcow2-linux-d551c4c43ccac3ef272e10ac23a64eaac16c23fd.tar.xz kernel-qcow2-linux-d551c4c43ccac3ef272e10ac23a64eaac16c23fd.zip | |
mfd: ab8500-debugfs: Apply a check for -ENOMEM after allocating memory for event name
The AB8500 debugfs driver allocates memory to contain the name of a new sysfs
entry, but fails to apply the proper post-allocation checks. If the device
were to run out of memory, the allocation would return NULL. Without the
correct checks the driver will continue to populate address NULL with the
specified device name which would obviously cause a pointer dereference Oops.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd')
| -rw-r--r-- | drivers/mfd/ab8500-debugfs.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index fe8189c4385a..e33e385af0a2 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -2804,6 +2804,9 @@ static ssize_t ab8500_subscribe_write(struct file *file, return -ENOMEM; event_name[irq_index] = kmalloc(count, GFP_KERNEL); + if (!event_name[irq_index]) + return -ENOMEM; + sprintf(event_name[irq_index], "%lu", user_val); dev_attr[irq_index]->show = show_irq; dev_attr[irq_index]->store = NULL; |