diff options
author | Andrew Donnellan | 2015-11-04 03:24:09 +0100 |
---|---|---|
committer | Michael Ellerman | 2015-11-24 04:21:27 +0100 |
commit | 48f0f6b717e314a30be121b67e1d044f6d311d66 (patch) | |
tree | c70bc458ed5dad06c56c42d3812e354808fdd0ea /drivers/misc/cxl/cxl.h | |
parent | cxl: Fix possible idr warning when contexts are released (diff) | |
download | kernel-qcow2-linux-48f0f6b717e314a30be121b67e1d044f6d311d66.tar.gz kernel-qcow2-linux-48f0f6b717e314a30be121b67e1d044f6d311d66.tar.xz kernel-qcow2-linux-48f0f6b717e314a30be121b67e1d044f6d311d66.zip |
cxl: use correct operator when writing pcie config space values
When writing a value to config space, cxl_pcie_write_config() calls
cxl_pcie_config_info() to obtain a mask and shift value, shifts the new
value accordingly, then uses the mask to combine the shifted value with the
existing value at the address as part of a read-modify-write pattern.
Currently, we use a logical OR operator rather than a bitwise OR operator,
which means any use of this function results in an incorrect value being
written. Replace the logical OR operator with a bitwise OR operator so the
value is written correctly.
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Cc: stable@vger.kernel.org
Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'drivers/misc/cxl/cxl.h')
0 files changed, 0 insertions, 0 deletions