diff options
| author | Oded Gabbay | 2019-03-31 20:37:42 +0200 |
|---|---|---|
| committer | Oded Gabbay | 2019-03-31 20:37:42 +0200 |
| commit | e850b89f50d2c1439f58d547b888ee6e43312dea (patch) | |
| tree | dc4ec47158e77460b6dc723fcd12bff3310960f1 /drivers/misc/habanalabs/memory.c | |
| parent | habanalabs: remove trailing blank line from EOF (diff) | |
| download | kernel-qcow2-linux-e850b89f50d2c1439f58d547b888ee6e43312dea.tar.gz kernel-qcow2-linux-e850b89f50d2c1439f58d547b888ee6e43312dea.tar.xz kernel-qcow2-linux-e850b89f50d2c1439f58d547b888ee6e43312dea.zip | |
habanalabs: prevent CPU soft lockup on Palladium
Unmapping ptes in the device MMU on Palladium can take a long time, which
can cause a kernel BUG of CPU soft lockup.
This patch minimize the chances for this bug by sleeping a little between
unmapping ptes.
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Diffstat (limited to 'drivers/misc/habanalabs/memory.c')
| -rw-r--r-- | drivers/misc/habanalabs/memory.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/drivers/misc/habanalabs/memory.c b/drivers/misc/habanalabs/memory.c index 39788b1cf8d0..e9e163545584 100644 --- a/drivers/misc/habanalabs/memory.c +++ b/drivers/misc/habanalabs/memory.c @@ -1046,10 +1046,17 @@ static int unmap_device_va(struct hl_ctx *ctx, u64 vaddr) mutex_lock(&ctx->mmu_lock); - for (i = 0 ; i < phys_pg_pack->npages ; i++, next_vaddr += page_size) + for (i = 0 ; i < phys_pg_pack->npages ; i++, next_vaddr += page_size) { if (hl_mmu_unmap(ctx, next_vaddr, page_size)) dev_warn_ratelimited(hdev->dev, - "unmap failed for vaddr: 0x%llx\n", next_vaddr); + "unmap failed for vaddr: 0x%llx\n", next_vaddr); + + /* unmapping on Palladium can be really long, so avoid a CPU + * soft lockup bug by sleeping a little between unmapping pages + */ + if (hdev->pldm) + usleep_range(500, 1000); + } hdev->asic_funcs->mmu_invalidate_cache(hdev, true); |