summaryrefslogtreecommitdiffstats
path: root/drivers/mtd/chips/jedec_probe.c
diff options
context:
space:
mode:
authorBoris Brezillon2017-11-30 18:01:30 +0100
committerBoris Brezillon2017-12-14 13:34:17 +0100
commit25f815f66a141436df8a4c45e5d2765272aea2ac (patch)
treec218dcaa4440f1cfbc62efbf67a1d80b72c5a4e1 /drivers/mtd/chips/jedec_probe.c
parentmtd: nand: provide several helpers to do common NAND operations (diff)
downloadkernel-qcow2-linux-25f815f66a141436df8a4c45e5d2765272aea2ac.tar.gz
kernel-qcow2-linux-25f815f66a141436df8a4c45e5d2765272aea2ac.tar.xz
kernel-qcow2-linux-25f815f66a141436df8a4c45e5d2765272aea2ac.zip
mtd: nand: force drivers to explicitly send READ/PROG commands
The core currently send the READ0 and SEQIN+PAGEPROG commands in nand_do_read/write_ops(). This is inconsistent with ->read/write_oob[_raw]() hooks behavior which are expected to send these commands. There's already a flag (NAND_ECC_CUSTOM_PAGE_ACCESS) to inform the core that a specific controller wants to send the READ/SEQIN+PAGEPROG commands on its own, but it's an opt-in flag, and existing drivers are unlikely to be updated to pass it. Moreover, some controllers cannot dissociate the READ/PAGEPROG commands from the associated data transfer and ECC engine activation, and developers have to hack things in their ->cmdfunc() implementation to handle such complex cases, or have to accept the perf penalty of sending twice the same command. To address this problem we are planning on adding a new interface which is passed all information about a NAND operation (including the amount of data to transfer) and replacing all calls to ->cmdfunc() to calls to this new ->exec_op() hook. But, in order to do that, we need to have all ->cmdfunc() calls placed near their associated ->read/write_buf/byte() calls. Modify the core and relevant drivers to make NAND_ECC_CUSTOM_PAGE_ACCESS the default case, and remove this flag. Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> [miquel.raynal@free-electrons.com: tested, fixed and rebased on nand/next] Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Diffstat (limited to 'drivers/mtd/chips/jedec_probe.c')
0 files changed, 0 insertions, 0 deletions