diff options
| author | Boris Brezillon | 2017-05-26 17:10:15 +0200 |
|---|---|---|
| committer | Boris Brezillon | 2017-05-30 08:59:26 +0200 |
| commit | 4a78cc644eed3cf2dae00c3a959910a86c140fd6 (patch) | |
| tree | 38f3d52750e2761fe156bb11f2e9f5c4907b86d4 /drivers/mtd/nand/denali.c | |
| parent | mtd: nand: export nand_{read,write}_page_raw() (diff) | |
| download | kernel-qcow2-linux-4a78cc644eed3cf2dae00c3a959910a86c140fd6.tar.gz kernel-qcow2-linux-4a78cc644eed3cf2dae00c3a959910a86c140fd6.tar.xz kernel-qcow2-linux-4a78cc644eed3cf2dae00c3a959910a86c140fd6.zip | |
mtd: nand: Make sure drivers not supporting SET/GET_FEATURES return -ENOTSUPP
A lot of drivers are providing their own ->cmdfunc(), and most of the
time this implementation does not support all possible NAND operations.
But since ->cmdfunc() cannot return an error code, the core has no way
to know that the operation it requested is not supported.
This is a problem we cannot address for all kind of operations with the
current design, but we can prevent these silent failures for the
GET/SET FEATURES operation by overloading the default
->onfi_{set,get}_features() methods with one returning -ENOTSUPP.
Reported-by: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Tested-by: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Diffstat (limited to 'drivers/mtd/nand/denali.c')
| -rw-r--r-- | drivers/mtd/nand/denali.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index 16634df2e39a..b3c99d98fdee 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -1531,6 +1531,8 @@ int denali_init(struct denali_nand_info *denali) chip->cmdfunc = denali_cmdfunc; chip->read_byte = denali_read_byte; chip->waitfunc = denali_waitfunc; + chip->onfi_set_features = nand_onfi_get_set_features_notsupp; + chip->onfi_get_features = nand_onfi_get_set_features_notsupp; /* * scan for NAND devices attached to the controller |