diff options
| author | Xiaolei Li | 2017-06-23 09:12:24 +0200 |
|---|---|---|
| committer | Boris Brezillon | 2017-06-25 16:54:01 +0200 |
| commit | 188986c70e09f0f3cd88e6fe14c89e439474e3ec (patch) | |
| tree | b8b196fa607d59e9fe9a5571f5f0357e1e6c49b6 /drivers/mtd | |
| parent | MAINTAINERS: add entry for Denali NAND controller driver (diff) | |
| download | kernel-qcow2-linux-188986c70e09f0f3cd88e6fe14c89e439474e3ec.tar.gz kernel-qcow2-linux-188986c70e09f0f3cd88e6fe14c89e439474e3ec.tar.xz kernel-qcow2-linux-188986c70e09f0f3cd88e6fe14c89e439474e3ec.zip | |
mtd: nand: mtk: fix incorrect register setting order about ecc irq
Currently, we trigger ECC HW before setting ecc irq. It is incorrect.
Because ECC starts working once the register ECC_CTL_REG is set as
ECC_OP_ENABLE. And this may lead an abnormal behavior of ecc irq.
So, should enable ecc irq at first, then trigger ECC.
Fixes: 1d6b1e464950 ("mtd: mediatek: driver for MTK Smart Device")
Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/nand/mtk_ecc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mtd/nand/mtk_ecc.c b/drivers/mtd/nand/mtk_ecc.c index 4958121cb827..a855a4e5cc35 100644 --- a/drivers/mtd/nand/mtk_ecc.c +++ b/drivers/mtd/nand/mtk_ecc.c @@ -276,8 +276,6 @@ int mtk_ecc_enable(struct mtk_ecc *ecc, struct mtk_ecc_config *config) if (ret) return ret; - writew(ECC_OP_ENABLE, ecc->regs + ECC_CTL_REG(op)); - init_completion(&ecc->done); reg_val = ECC_IRQ_EN; /* @@ -289,6 +287,8 @@ int mtk_ecc_enable(struct mtk_ecc *ecc, struct mtk_ecc_config *config) reg_val |= ECC_PG_IRQ_SEL; writew(reg_val, ecc->regs + ECC_IRQ_REG(op)); + writew(ECC_OP_ENABLE, ecc->regs + ECC_CTL_REG(op)); + return 0; } EXPORT_SYMBOL(mtk_ecc_enable); |