diff options
author | Joe Jin | 2010-12-06 04:00:59 +0100 |
---|---|---|
committer | David S. Miller | 2010-12-08 21:13:43 +0100 |
commit | 408cc293c29ada769ae772420a39961320da1854 (patch) | |
tree | 939e8ef335d708373bcd14682df2c507a1fed7b1 /drivers/net/benet/be_cmds.c | |
parent | l2tp: Fix modalias of l2tp_ip (diff) | |
download | kernel-qcow2-linux-408cc293c29ada769ae772420a39961320da1854.tar.gz kernel-qcow2-linux-408cc293c29ada769ae772420a39961320da1854.tar.xz kernel-qcow2-linux-408cc293c29ada769ae772420a39961320da1854.zip |
driver/net/benet: fix be_cmd_multicast_set() memcpy bug
Regarding benet be_cmd_multicast_set() function, now using
netdev_for_each_mc_addr() helper for mac address copy, but
when copying to req->mac[] did not increase of the index.
Cc: Sathya Perla <sathyap@serverengines.com>
Cc: Subbu Seetharaman <subbus@serverengines.com>
Cc: Sarveshwar Bandi <sarveshwarb@serverengines.com>
Cc: Ajit Khaparde <ajitk@serverengines.com>
Signed-off-by: Joe Jin <joe.jin@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/benet/be_cmds.c')
-rw-r--r-- | drivers/net/benet/be_cmds.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c index 36eca1ce75d4..e4465d222a7d 100644 --- a/drivers/net/benet/be_cmds.c +++ b/drivers/net/benet/be_cmds.c @@ -1235,7 +1235,7 @@ int be_cmd_multicast_set(struct be_adapter *adapter, u32 if_id, i = 0; netdev_for_each_mc_addr(ha, netdev) - memcpy(req->mac[i].byte, ha->addr, ETH_ALEN); + memcpy(req->mac[i++].byte, ha->addr, ETH_ALEN); } else { req->promiscuous = 1; } |