diff options
| author | Dan Carpenter | 2011-11-04 09:21:38 +0100 |
|---|---|---|
| committer | David S. Miller | 2011-11-04 23:37:23 +0100 |
| commit | 589665f5a6008dbce1d0af2cb93e94a80bf78151 (patch) | |
| tree | 4f4ec1949dd233a8474c2cb477da3637166b6e75 /drivers/net/bonding/bond_main.c | |
| parent | sky2: fix regression on Yukon Optima (diff) | |
| download | kernel-qcow2-linux-589665f5a6008dbce1d0af2cb93e94a80bf78151.tar.gz kernel-qcow2-linux-589665f5a6008dbce1d0af2cb93e94a80bf78151.tar.xz kernel-qcow2-linux-589665f5a6008dbce1d0af2cb93e94a80bf78151.zip | |
bonding: comparing a u8 with -1 is always false
slave->duplex is a u8 type so the in bond_info_show_slave() when we
check "if (slave->duplex == -1)", it's always false.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding/bond_main.c')
| -rw-r--r-- | drivers/net/bonding/bond_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index b2b9109b6712..b0c577256487 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -560,8 +560,8 @@ static int bond_update_speed_duplex(struct slave *slave) u32 slave_speed; int res; - slave->speed = -1; - slave->duplex = -1; + slave->speed = SPEED_UNKNOWN; + slave->duplex = DUPLEX_UNKNOWN; res = __ethtool_get_settings(slave_dev, &ecmd); if (res < 0) |