diff options
| author | Veaceslav Falico | 2014-05-15 21:39:59 +0200 |
|---|---|---|
| committer | David S. Miller | 2014-05-16 22:34:33 +0200 |
| commit | 8557cd74ca8af9a71ae19d445e33d92bd50a6dc5 (patch) | |
| tree | c6ad54191e3ed0afc12f62cd5f546189058ec096 /drivers/net/bonding/bond_main.c | |
| parent | bonding: rename {, bond_}slave_can_tx and clean it up (diff) | |
| download | kernel-qcow2-linux-8557cd74ca8af9a71ae19d445e33d92bd50a6dc5.tar.gz kernel-qcow2-linux-8557cd74ca8af9a71ae19d445e33d92bd50a6dc5.tar.xz kernel-qcow2-linux-8557cd74ca8af9a71ae19d445e33d92bd50a6dc5.zip | |
bonding: replace SLAVE_IS_OK() with bond_slave_can_tx()
They're verifying the same thing (except of IFF_UP, which is implied for
netif_running(), which is also a prerequisite).
CC: Jay Vosburgh <j.vosburgh@gmail.com>
CC: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: Veaceslav Falico <vfalico@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding/bond_main.c')
| -rw-r--r-- | drivers/net/bonding/bond_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 5a1e7b779cbe..712320532105 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -3850,14 +3850,14 @@ static int bond_ethtool_get_settings(struct net_device *bond_dev, ecmd->duplex = DUPLEX_UNKNOWN; ecmd->port = PORT_OTHER; - /* Since SLAVE_IS_OK returns false for all inactive or down slaves, we + /* Since bond_slave_can_tx returns false for all inactive or down slaves, we * do not need to check mode. Though link speed might not represent * the true receive or transmit bandwidth (not all modes are symmetric) * this is an accurate maximum. */ read_lock(&bond->lock); bond_for_each_slave(bond, slave, iter) { - if (SLAVE_IS_OK(slave)) { + if (bond_slave_can_tx(slave)) { if (slave->speed != SPEED_UNKNOWN) speed += slave->speed; if (ecmd->duplex == DUPLEX_UNKNOWN && |