diff options
| author | Nikolay Aleksandrov | 2014-09-11 22:49:28 +0200 |
|---|---|---|
| committer | David S. Miller | 2014-09-13 22:29:07 +0200 |
| commit | 8c0bc550288d81e9ad8a2ed9136a72140b9ef507 (patch) | |
| tree | 40b4a29e8721c329dbc2d1b2332f4beecbef45e5 /drivers/net/bonding/bond_main.c | |
| parent | bonding: 3ad: convert to bond->mode_lock (diff) | |
| download | kernel-qcow2-linux-8c0bc550288d81e9ad8a2ed9136a72140b9ef507.tar.gz kernel-qcow2-linux-8c0bc550288d81e9ad8a2ed9136a72140b9ef507.tar.xz kernel-qcow2-linux-8c0bc550288d81e9ad8a2ed9136a72140b9ef507.zip | |
bonding: adjust locking comments
Now that locks have been removed, remove some unnecessary comments and
adjust others to reflect reality. Also add a comment to "mode_lock" to
describe its current users and give a brief summary why they need it.
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding/bond_main.c')
| -rw-r--r-- | drivers/net/bonding/bond_main.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 116cf6965bc5..2d90a8b7f62e 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1629,7 +1629,7 @@ err_undo_flags: /* * Try to release the slave device <slave> from the bond device <master> * It is legal to access curr_active_slave without a lock because all the function - * is write-locked. If "all" is true it means that the function is being called + * is RTNL-locked. If "all" is true it means that the function is being called * while destroying a bond interface and all slaves are being released. * * The rules for slave state should be: @@ -2494,7 +2494,7 @@ re_arm: * place for the slave. Returns 0 if no changes are found, >0 if changes * to link states must be committed. * - * Called with rcu_read_lock hold. + * Called with rcu_read_lock held. */ static int bond_ab_arp_inspect(struct bonding *bond) { @@ -2642,7 +2642,7 @@ do_failover: /* * Send ARP probes for active-backup mode ARP monitor. * - * Called with rcu_read_lock hold. + * Called with rcu_read_lock held. */ static bool bond_ab_arp_probe(struct bonding *bond) { |