diff options
| author | Vladimir Oltean | 2019-06-27 23:46:37 +0200 |
|---|---|---|
| committer | David S. Miller | 2019-06-28 18:31:31 +0200 |
| commit | 9f971573d96fc55efe9d48ff2ca160c9b95fbe37 (patch) | |
| tree | 8e0204f87c8192623a23433a7fdffafe33c74d3d /drivers/net/dsa/sja1105/sja1105_main.c | |
| parent | net: dsa: sja1105: Check for PHY mode mismatches with what PHYLINK reports (diff) | |
| download | kernel-qcow2-linux-9f971573d96fc55efe9d48ff2ca160c9b95fbe37.tar.gz kernel-qcow2-linux-9f971573d96fc55efe9d48ff2ca160c9b95fbe37.tar.xz kernel-qcow2-linux-9f971573d96fc55efe9d48ff2ca160c9b95fbe37.zip | |
net: dsa: sja1105: Mark in-band AN modes not supported for PHYLINK
We need a better way to signal this, perhaps in phylink_validate, but
for now just print this error message as guidance for other people
looking at this driver's code while trying to rework PHYLINK.
Cc: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa/sja1105/sja1105_main.c')
| -rw-r--r-- | drivers/net/dsa/sja1105/sja1105_main.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c index b366b8e100f8..32bf3a7cc3b6 100644 --- a/drivers/net/dsa/sja1105/sja1105_main.c +++ b/drivers/net/dsa/sja1105/sja1105_main.c @@ -806,6 +806,11 @@ static void sja1105_mac_config(struct dsa_switch *ds, int port, if (sja1105_phy_mode_mismatch(priv, port, state->interface)) return; + if (link_an_mode == MLO_AN_INBAND) { + dev_err(ds->dev, "In-band AN not supported!\n"); + return; + } + sja1105_adjust_port_config(priv, port, state->speed); } |