diff options
| author | Merav Sicron | 2012-08-27 05:26:19 +0200 |
|---|---|---|
| committer | David S. Miller | 2012-08-30 19:36:46 +0200 |
| commit | 26614ba5445fe31a69068a5e94266fa08b4ee345 (patch) | |
| tree | f2c3ddd616e9cd031446d25c1e5e29649be7b0e3 /drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | |
| parent | ipv4: must use rcu protection while calling fib_lookup (diff) | |
| download | kernel-qcow2-linux-26614ba5445fe31a69068a5e94266fa08b4ee345.tar.gz kernel-qcow2-linux-26614ba5445fe31a69068a5e94266fa08b4ee345.tar.xz kernel-qcow2-linux-26614ba5445fe31a69068a5e94266fa08b4ee345.zip | |
bnx2x: Move netif_napi_add to the open call
Move netif_napi_add for all queues from the probe call to the open call, to
avoid the case that napi objects are added for queues that may eventually not
be initialized and activated. With the former behavior, the driver could crash
when netpoll was calling ndo_poll_controller.
Signed-off-by: Merav Sicron <meravs@broadcom.com>
Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index e879e19eb0d6..af20c6ee2cd9 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c @@ -2046,6 +2046,8 @@ int bnx2x_nic_load(struct bnx2x *bp, int load_mode) */ bnx2x_setup_tc(bp->dev, bp->max_cos); + /* Add all NAPI objects */ + bnx2x_add_all_napi(bp); bnx2x_napi_enable(bp); /* set pf load just before approaching the MCP */ @@ -2408,6 +2410,8 @@ int bnx2x_nic_unload(struct bnx2x *bp, int unload_mode) /* Disable HW interrupts, NAPI */ bnx2x_netif_stop(bp, 1); + /* Delete all NAPI objects */ + bnx2x_del_all_napi(bp); /* Release IRQs */ bnx2x_free_irq(bp); |