diff options
| author | Michael Chan | 2016-02-26 10:00:07 +0100 |
|---|---|---|
| committer | David S. Miller | 2016-03-01 21:37:02 +0100 |
| commit | fbfbc4851dd709cf1327afc283f9cca00235dcb3 (patch) | |
| tree | e21d0767b734b760bb6565670476d4bec9d24b9a /drivers/net/ethernet/broadcom/bnxt/bnxt.c | |
| parent | bnxt_en: Add installed-package firmware version reporting via Ethtool GDRVINFO (diff) | |
| download | kernel-qcow2-linux-fbfbc4851dd709cf1327afc283f9cca00235dcb3.tar.gz kernel-qcow2-linux-fbfbc4851dd709cf1327afc283f9cca00235dcb3.tar.xz kernel-qcow2-linux-fbfbc4851dd709cf1327afc283f9cca00235dcb3.zip | |
bnxt_en: Refactor _hwrm_send_message().
Add a new function bnxt_do_send_msg() to do essentially the same thing
with an additional paramter to silence error response messages. All
current callers will set silent to false.
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bnxt/bnxt.c')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt.c | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 6e45a00905b9..48a7bbc7cc25 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -2608,7 +2608,8 @@ void bnxt_hwrm_cmd_hdr_init(struct bnxt *bp, void *request, u16 req_type, req->resp_addr = cpu_to_le64(bp->hwrm_cmd_resp_dma_addr); } -int _hwrm_send_message(struct bnxt *bp, void *msg, u32 msg_len, int timeout) +static int bnxt_hwrm_do_send_msg(struct bnxt *bp, void *msg, u32 msg_len, + int timeout, bool silent) { int i, intr_process, rc; struct input *req = msg; @@ -2686,13 +2687,16 @@ int _hwrm_send_message(struct bnxt *bp, void *msg, u32 msg_len, int timeout) } rc = le16_to_cpu(resp->error_code); - if (rc) { + if (rc && !silent) netdev_err(bp->dev, "hwrm req_type 0x%x seq id 0x%x error 0x%x\n", le16_to_cpu(resp->req_type), le16_to_cpu(resp->seq_id), rc); - return rc; - } - return 0; + return rc; +} + +int _hwrm_send_message(struct bnxt *bp, void *msg, u32 msg_len, int timeout) +{ + return bnxt_hwrm_do_send_msg(bp, msg, msg_len, timeout, false); } int hwrm_send_message(struct bnxt *bp, void *msg, u32 msg_len, int timeout) |