diff options
| author | Markus Elfring | 2015-06-29 12:22:24 +0200 |
|---|---|---|
| committer | David S. Miller | 2015-06-29 18:28:14 +0200 |
| commit | 9686f3109a9b2190029cbc9bf3e0ee2e0e224eaf (patch) | |
| tree | 856539472ac43097cf0eeb9f5a91e08df0add1dd /drivers/net/ethernet/cavium/liquidio/octeon_device.c | |
| parent | vmxnet3: Bump up driver version number (diff) | |
| download | kernel-qcow2-linux-9686f3109a9b2190029cbc9bf3e0ee2e0e224eaf.tar.gz kernel-qcow2-linux-9686f3109a9b2190029cbc9bf3e0ee2e0e224eaf.tar.xz kernel-qcow2-linux-9686f3109a9b2190029cbc9bf3e0ee2e0e224eaf.zip | |
net-Liquidio: Delete unnecessary checks before the function call "vfree"
The vfree() function performs also input parameter validation.
Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/cavium/liquidio/octeon_device.c')
| -rw-r--r-- | drivers/net/ethernet/cavium/liquidio/octeon_device.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c index 0d3106b464b2..f67641a2ff9e 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c @@ -650,14 +650,12 @@ void octeon_free_device_mem(struct octeon_device *oct) for (i = 0; i < MAX_OCTEON_OUTPUT_QUEUES; i++) { /* could check mask as well */ - if (oct->droq[i]) - vfree(oct->droq[i]); + vfree(oct->droq[i]); } for (i = 0; i < MAX_OCTEON_INSTR_QUEUES; i++) { /* could check mask as well */ - if (oct->instr_queue[i]) - vfree(oct->instr_queue[i]); + vfree(oct->instr_queue[i]); } i = oct->octeon_id; @@ -1078,10 +1076,7 @@ octeon_unregister_dispatch_fn(struct octeon_device *oct, u16 opcode, oct->dispatch.count--; spin_unlock_bh(&oct->dispatch.lock); - - if (dfree) - vfree(dfree); - + vfree(dfree); return retval; } |