summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/hp
diff options
context:
space:
mode:
authorDavid Howells2017-04-04 17:54:26 +0200
committerDavid Howells2017-04-20 13:02:32 +0200
commitdf29840815a6aaa6a1ab8d85d7745a1a6fc25de0 (patch)
treea136f12e73075fb30525de0adfa6c9e17c36a7f9 /drivers/net/ethernet/hp
parentAnnotate hardware config module parameters in drivers/net/can/ (diff)
downloadkernel-qcow2-linux-df29840815a6aaa6a1ab8d85d7745a1a6fc25de0.tar.gz
kernel-qcow2-linux-df29840815a6aaa6a1ab8d85d7745a1a6fc25de0.tar.xz
kernel-qcow2-linux-df29840815a6aaa6a1ab8d85d7745a1a6fc25de0.zip
Annotate hardware config module parameters in drivers/net/ethernet/
When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a device to access or modify the kernel image. To this end, annotate module_param* statements that refer to hardware configuration and indicate for future reference what type of parameter they specify. The parameter parser in the core sees this information and can skip such parameters with an error message if the kernel is locked down. The module initialisation then runs as normal, but just sees whatever the default values for those parameters is. Note that we do still need to do the module initialisation because some drivers have viable defaults set in case parameters aren't specified and some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/net/ethernet/. Suggested-by: Alan Cox <gnomes@lxorguk.ukuu.org.uk> Signed-off-by: David Howells <dhowells@redhat.com> cc: Steffen Klassert <steffen.klassert@secunet.com> cc: Jaroslav Kysela <perex@perex.cz> cc: netdev@vger.kernel.org cc: linux-parisc@vger.kernel.org
Diffstat (limited to 'drivers/net/ethernet/hp')
-rw-r--r--drivers/net/ethernet/hp/hp100.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/hp/hp100.c b/drivers/net/ethernet/hp/hp100.c
index 1a31bee6e728..5673b071e39d 100644
--- a/drivers/net/ethernet/hp/hp100.c
+++ b/drivers/net/ethernet/hp/hp100.c
@@ -2966,7 +2966,7 @@ MODULE_DESCRIPTION("HP CASCADE Architecture Driver for 100VG-AnyLan Network Adap
#define HP100_DEVICES 5
/* Parameters set by insmod */
static int hp100_port[HP100_DEVICES] = { 0, [1 ... (HP100_DEVICES-1)] = -1 };
-module_param_array(hp100_port, int, NULL, 0);
+module_param_hw_array(hp100_port, int, ioport, NULL, 0);
/* List of devices */
static struct net_device *hp100_devlist[HP100_DEVICES];