diff options
| author | Jesse Brandeburg | 2015-08-26 21:14:19 +0200 |
|---|---|---|
| committer | Jeff Kirsher | 2015-10-07 23:23:09 +0200 |
| commit | a72a5abcb37beac163704efba6a3d33ebca4d90a (patch) | |
| tree | 7922bf1bc1bcffb8ffc96353f684f295eb2d1b65 /drivers/net/ethernet/intel/i40e/i40e_prototype.h | |
| parent | i40e: add little endian conversion for checksum (diff) | |
| download | kernel-qcow2-linux-a72a5abcb37beac163704efba6a3d33ebca4d90a.tar.gz kernel-qcow2-linux-a72a5abcb37beac163704efba6a3d33ebca4d90a.tar.xz kernel-qcow2-linux-a72a5abcb37beac163704efba6a3d33ebca4d90a.zip | |
i40e: fix bug in return from get_link_status and avoid spurious link messages
Previously, the driver could call this function and have only true/false
returned, but false could mean multiple things like failure to read
or link was down. This change allows the caller to get all return values
in the call chain bubbled back to the source, which keeps information about
failures from being lost.
Also, in some unlikely scenarios, the firmware can become slow to respond
to admin queue (AQ) queries for link state. Should the AQ time out,
the driver can detect the state and avoid a link change when there
may have been none.
Change-ID: Ib2ac38407b7880750fb891b392fa77457fe6c21c
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/i40e/i40e_prototype.h')
| -rw-r--r-- | drivers/net/ethernet/intel/i40e/i40e_prototype.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_prototype.h b/drivers/net/ethernet/intel/i40e/i40e_prototype.h index dcb72a8ee8e5..e51e1567837c 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_prototype.h +++ b/drivers/net/ethernet/intel/i40e/i40e_prototype.h @@ -258,7 +258,7 @@ i40e_status i40e_init_shared_code(struct i40e_hw *hw); i40e_status i40e_pf_reset(struct i40e_hw *hw); void i40e_clear_hw(struct i40e_hw *hw); void i40e_clear_pxe_mode(struct i40e_hw *hw); -bool i40e_get_link_status(struct i40e_hw *hw); +i40e_status i40e_get_link_status(struct i40e_hw *hw, bool *link_up); i40e_status i40e_get_mac_addr(struct i40e_hw *hw, u8 *mac_addr); i40e_status i40e_read_bw_from_alt_ram(struct i40e_hw *hw, u32 *max_bw, u32 *min_bw, bool *min_valid, |