diff options
| author | Mitch Williams | 2014-04-09 07:58:57 +0200 |
|---|---|---|
| committer | Jeff Kirsher | 2014-05-29 11:37:38 +0200 |
| commit | 84590fd90ee423fb815abc8301d277f0b693b2f6 (patch) | |
| tree | 5d293e66cb0a77aba38cc845dc2351e9248dce87 /drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | |
| parent | i40evf: don't round Tx rate down to 0 (diff) | |
| download | kernel-qcow2-linux-84590fd90ee423fb815abc8301d277f0b693b2f6.tar.gz kernel-qcow2-linux-84590fd90ee423fb815abc8301d277f0b693b2f6.tar.xz kernel-qcow2-linux-84590fd90ee423fb815abc8301d277f0b693b2f6.zip | |
i40evf: tweak Tx rate params and de-magic-ify
In order for the VF to achieve its programmed Tx rate, we need to set
the max credits value to 4. While we're at it, get rid of some magic
numbers.
Change-ID: I4f17b4d3a90f1e069bdd134a543f0aa22feac3a9
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Sibai Li <sibai.li@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c')
| -rw-r--r-- | drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c index 395c546166c3..4e7634c83685 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c @@ -2198,6 +2198,8 @@ error_pvid: return ret; } +#define I40E_BW_CREDIT_DIVISOR 50 /* 50Mbps per BW credit */ +#define I40E_MAX_BW_INACTIVE_ACCUM 4 /* device can accumulate 4 credits max */ /** * i40e_ndo_set_vf_bw * @netdev: network interface device structure @@ -2264,8 +2266,9 @@ int i40e_ndo_set_vf_bw(struct net_device *netdev, int vf_id, int min_tx_rate, } /* Tx rate credits are in values of 50Mbps, 0 is disabled*/ - ret = i40e_aq_config_vsi_bw_limit(&pf->hw, vsi->seid, max_tx_rate / 50, - 0, NULL); + ret = i40e_aq_config_vsi_bw_limit(&pf->hw, vsi->seid, + max_tx_rate / I40E_BW_CREDIT_DIVISOR, + I40E_MAX_BW_INACTIVE_ACCUM, NULL); if (ret) { dev_err(&pf->pdev->dev, "Unable to set max tx rate, error code %d.\n", ret); |