summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
diff options
context:
space:
mode:
authorMark Rustad2015-04-10 19:36:36 +0200
committerJeff Kirsher2015-05-04 11:31:13 +0200
commita1e869de72a7a6d9e1007d0b459e79e91f0cf5b5 (patch)
tree81bc66fcd99b7b3668dbeb22da80b46c148519a3 /drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
parentixgbe: Release semaphore bits in the right order (diff)
downloadkernel-qcow2-linux-a1e869de72a7a6d9e1007d0b459e79e91f0cf5b5.tar.gz
kernel-qcow2-linux-a1e869de72a7a6d9e1007d0b459e79e91f0cf5b5.tar.xz
kernel-qcow2-linux-a1e869de72a7a6d9e1007d0b459e79e91f0cf5b5.zip
ixgbe: Use a signed type to hold error codes
Because error codes are negative, it only makes sense to consistently use signed types when handling them. Also remove some explicit comparisons with 0 on these variables. Signed-off-by: Mark Rustad <mark.d.rustad@intel.com> Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c')
-rw-r--r--drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
index 58ab7d9538e7..b0236985e915 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
@@ -1063,7 +1063,7 @@ static s32 ixgbe_setup_kr_x550em(struct ixgbe_hw *hw)
**/
static s32 ixgbe_setup_internal_phy_x550em(struct ixgbe_hw *hw)
{
- u32 status;
+ s32 status;
u16 lasi, autoneg_status, speed;
ixgbe_link_speed force_speed;
@@ -1205,7 +1205,7 @@ static enum ixgbe_media_type ixgbe_get_media_type_X550em(struct ixgbe_hw *hw)
**/
static s32 ixgbe_init_ext_t_x550em(struct ixgbe_hw *hw)
{
- u32 status;
+ s32 status;
u16 reg;
u32 retries = 2;