diff options
| author | Carolyn Wyborny | 2017-07-14 15:10:07 +0200 |
|---|---|---|
| committer | Jeff Kirsher | 2017-08-28 01:02:16 +0200 |
| commit | 19279235bea221798e3307a8bec2c02559cab0c5 (patch) | |
| tree | 532a9d761ef68ff706032b74b0a4f87d3a136866 /drivers/net/ethernet/intel | |
| parent | i40e: 25G FEC status improvements (diff) | |
| download | kernel-qcow2-linux-19279235bea221798e3307a8bec2c02559cab0c5.tar.gz kernel-qcow2-linux-19279235bea221798e3307a8bec2c02559cab0c5.tar.xz kernel-qcow2-linux-19279235bea221798e3307a8bec2c02559cab0c5.zip | |
i40e: Fix for unused value issue found by static analysis
This patch fixes an issue where an error return value is
set, but without an immediate exit, the value can be overwritten
by the following code execution. The condition at this point
is not fatal, so remove the error assignment and comment the
intent for future code maintainers
Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel')
| -rw-r--r-- | drivers/net/ethernet/intel/i40e/i40e_main.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 5a06cd23b9e6..0962b85ef6f3 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -9884,13 +9884,15 @@ static int i40e_add_vsi(struct i40e_vsi *vsi) */ ret = i40e_vsi_config_tc(vsi, enabled_tc); if (ret) { + /* Single TC condition is not fatal, + * message and continue + */ dev_info(&pf->pdev->dev, "failed to configure TCs for main VSI tc_map 0x%08x, err %s aq_err %s\n", enabled_tc, i40e_stat_str(&pf->hw, ret), i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status)); - ret = -ENOENT; } } break; |