diff options
| author | Jack Morgenstein | 2016-12-29 17:37:09 +0100 |
|---|---|---|
| committer | David S. Miller | 2016-12-29 20:17:40 +0100 |
| commit | 3b01fe7f91c8e4f9afc4fae3c5af72c14958d2d8 (patch) | |
| tree | 307ef0cf010790193b9cef2dd467ffe58e353c95 /drivers/net/ethernet/mellanox/mlx4/en_rx.c | |
| parent | net: fix incorrect original ingress device index in PKTINFO (diff) | |
| download | kernel-qcow2-linux-3b01fe7f91c8e4f9afc4fae3c5af72c14958d2d8.tar.gz kernel-qcow2-linux-3b01fe7f91c8e4f9afc4fae3c5af72c14958d2d8.tar.xz kernel-qcow2-linux-3b01fe7f91c8e4f9afc4fae3c5af72c14958d2d8.zip | |
net/mlx4_core: Use-after-free causes a resource leak in flow-steering detach
mlx4_QP_FLOW_STEERING_DETACH_wrapper first removes the steering
rule (which results in freeing the rule structure), and then
references a field in this struct (the qp number) when releasing the
busy-status on the rule's qp.
Since this memory was freed, it could reallocated and changed.
Therefore, the qp number in the struct may be incorrect,
so that we are releasing the incorrect qp. This leaves the rule's qp
in the busy state (and could possibly release an incorrect qp as well).
Fix this by saving the qp number in a local variable, for use after
removing the steering rule.
Fixes: 2c473ae7e582 ("net/mlx4_core: Disallow releasing VF QPs which have steering rules")
Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlx4/en_rx.c')
0 files changed, 0 insertions, 0 deletions