summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
diff options
context:
space:
mode:
authorCong Wang2018-12-04 07:14:04 +0100
committerSaeed Mahameed2019-01-19 01:15:30 +0100
commite8c8b53ccaff568fef4c13a6ccaf08bf241aa01a (patch)
treed5ae7059af99e0809dd048f3de4d84d899515d34 /drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
parentLinux 5.0-rc1 (diff)
downloadkernel-qcow2-linux-e8c8b53ccaff568fef4c13a6ccaf08bf241aa01a.tar.gz
kernel-qcow2-linux-e8c8b53ccaff568fef4c13a6ccaf08bf241aa01a.tar.xz
kernel-qcow2-linux-e8c8b53ccaff568fef4c13a6ccaf08bf241aa01a.zip
net/mlx5e: Force CHECKSUM_UNNECESSARY for short ethernet frames
When an ethernet frame is padded to meet the minimum ethernet frame size, the padding octets are not covered by the hardware checksum. Fortunately the padding octets are usually zero's, which don't affect checksum. However, we have a switch which pads non-zero octets, this causes kernel hardware checksum fault repeatedly. Prior to: commit '88078d98d1bb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE ...")' skb checksum was forced to be CHECKSUM_NONE when padding is detected. After it, we need to keep skb->csum updated, like what we do for RXFCS. However, fixing up CHECKSUM_COMPLETE requires to verify and parse IP headers, it is not worthy the effort as the packets are so small that CHECKSUM_COMPLETE can't save anything. Fixes: 88078d98d1bb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends"), Cc: Eric Dumazet <edumazet@google.com> Cc: Tariq Toukan <tariqt@mellanox.com> Cc: Nikola Ciprich <nikola.ciprich@linuxbox.cz> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c')
0 files changed, 0 insertions, 0 deletions