summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
diff options
context:
space:
mode:
authorDan Carpenter2015-06-11 10:50:01 +0200
committerDavid S. Miller2015-06-12 00:44:41 +0200
commit7ec0bb227aa6fb8c622bec91933e865b37dc58f2 (patch)
treeaf1d96bb2179c5973efee4d46ff6136ffbc82901 /drivers/net/ethernet/mellanox/mlx5/core/en_main.c
parentvxge: use swap() in vxge_hw_channel_dtr_alloc() (diff)
downloadkernel-qcow2-linux-7ec0bb227aa6fb8c622bec91933e865b37dc58f2.tar.gz
kernel-qcow2-linux-7ec0bb227aa6fb8c622bec91933e865b37dc58f2.tar.xz
kernel-qcow2-linux-7ec0bb227aa6fb8c622bec91933e865b37dc58f2.zip
net/mlx5_core: fix an error code
We return success if mlx5e_alloc_sq_db() fails but we should return an error code. Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Or Gerlitz <ogerlitz@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlx5/core/en_main.c')
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/en_main.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index 7348c5173aa9..075e5175e779 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -525,7 +525,8 @@ static int mlx5e_create_sq(struct mlx5e_channel *c,
sq->uar_map = sq->uar.map;
sq->bf_buf_size = (1 << MLX5_CAP_GEN(mdev, log_bf_reg_size)) / 2;
- if (mlx5e_alloc_sq_db(sq, cpu_to_node(c->cpu)))
+ err = mlx5e_alloc_sq_db(sq, cpu_to_node(c->cpu));
+ if (err)
goto err_sq_wq_destroy;
sq->txq = netdev_get_tx_queue(priv->netdev,