diff options
| author | Jakub Kicinski | 2017-10-12 19:34:09 +0200 |
|---|---|---|
| committer | David S. Miller | 2017-10-14 20:13:28 +0200 |
| commit | 8283737065b2dab480cd10e00e6f8abbcb62b5b0 (patch) | |
| tree | 907b0964d517b5b97c150fd83440fdfec8a5346d /drivers/net/ethernet/netronome/nfp/bpf/jit.c | |
| parent | nfp: bpf: reorder arguments to emit_ld_field_any() (diff) | |
| download | kernel-qcow2-linux-8283737065b2dab480cd10e00e6f8abbcb62b5b0.tar.gz kernel-qcow2-linux-8283737065b2dab480cd10e00e6f8abbcb62b5b0.tar.xz kernel-qcow2-linux-8283737065b2dab480cd10e00e6f8abbcb62b5b0.zip | |
nfp: bpf: add missing return in jne_imm optimization
We optimize comparisons to immediate 0 as if (reg.lo | reg.hi).
The early return statement was missing, however, which means we
would generate two comparisons - optimized one followed by a
normal 2x 32 bit compare.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/netronome/nfp/bpf/jit.c')
| -rw-r--r-- | drivers/net/ethernet/netronome/nfp/bpf/jit.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/netronome/nfp/bpf/jit.c b/drivers/net/ethernet/netronome/nfp/bpf/jit.c index cf8a6eb3ec99..5ac834e91aed 100644 --- a/drivers/net/ethernet/netronome/nfp/bpf/jit.c +++ b/drivers/net/ethernet/netronome/nfp/bpf/jit.c @@ -1191,6 +1191,7 @@ static int jne_imm(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta) emit_alu(nfp_prog, reg_none(), reg_a(insn->dst_reg * 2), ALU_OP_OR, reg_b(insn->dst_reg * 2 + 1)); emit_br(nfp_prog, BR_BNE, insn->off, 0); + return 0; } tmp_reg = ur_load_imm_any(nfp_prog, imm & ~0U, imm_b(nfp_prog)); |