summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/rocker/rocker.c
diff options
context:
space:
mode:
authorWei Yongjun2015-04-16 14:21:02 +0200
committerDavid S. Miller2015-04-16 18:13:39 +0200
commit3122a92e80957e30ea9afd963128c6e6c0f5c2ac (patch)
treea21818b6061e0575d95db190814db321a385e2ea /drivers/net/ethernet/rocker/rocker.c
parentdsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state (diff)
downloadkernel-qcow2-linux-3122a92e80957e30ea9afd963128c6e6c0f5c2ac.tar.gz
kernel-qcow2-linux-3122a92e80957e30ea9afd963128c6e6c0f5c2ac.tar.xz
kernel-qcow2-linux-3122a92e80957e30ea9afd963128c6e6c0f5c2ac.zip
rocker: fix error return code in rocker_probe()
Fix to return -EINVAL from the invalid PCI region size error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/rocker/rocker.c')
-rw-r--r--drivers/net/ethernet/rocker/rocker.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
index a87b177bd723..a570a60533be 100644
--- a/drivers/net/ethernet/rocker/rocker.c
+++ b/drivers/net/ethernet/rocker/rocker.c
@@ -4759,6 +4759,7 @@ static int rocker_probe(struct pci_dev *pdev, const struct pci_device_id *id)
if (pci_resource_len(pdev, 0) < ROCKER_PCI_BAR0_SIZE) {
dev_err(&pdev->dev, "invalid PCI region size\n");
+ err = -EINVAL;
goto err_pci_resource_len_check;
}