diff options
| author | Claudiu Manoil | 2017-09-04 09:45:28 +0200 |
|---|---|---|
| committer | David S. Miller | 2017-09-05 23:34:45 +0200 |
| commit | 5d621672bc1a1e5090c1ac5432a18c79e0e13e03 (patch) | |
| tree | 22e23d01839dc650354d1196e303fca56f057e42 /drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | |
| parent | cxgb4: Ignore MPS_TX_INT_CAUSE[Bubble] for T6 (diff) | |
| download | kernel-qcow2-linux-5d621672bc1a1e5090c1ac5432a18c79e0e13e03.tar.gz kernel-qcow2-linux-5d621672bc1a1e5090c1ac5432a18c79e0e13e03.tar.xz kernel-qcow2-linux-5d621672bc1a1e5090c1ac5432a18c79e0e13e03.zip | |
gianfar: Fix Tx flow control deactivation
The wrong register is checked for the Tx flow control bit,
it should have been maccfg1 not maccfg2.
This went unnoticed for so long probably because the impact is
hardly visible, not to mention the tangled code from adjust_link().
First, link flow control (i.e. handling of Rx/Tx link level pause frames)
is disabled by default (needs to be enabled via 'ethtool -A').
Secondly, maccfg2 always returns 0 for tx_flow_oldval (except for a few
old boards), which results in Tx flow control remaining always on
once activated.
Fixes: 45b679c9a3ccd9e34f28e6ec677b812a860eb8eb ("gianfar: Implement PAUSE frame generation support")
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c')
0 files changed, 0 insertions, 0 deletions