diff options
| author | Linus Torvalds | 2009-11-18 22:31:52 +0100 |
|---|---|---|
| committer | Linus Torvalds | 2009-11-19 02:18:13 +0100 |
| commit | a414f01ac2899f273ef8fe98fa44158ac12793f2 (patch) | |
| tree | 30a7ef8d7d2f8d4aca0781fa8785630fc1f6320d /drivers/net/ixgbe/ixgbe_ethtool.c | |
| parent | Merge branch 'agp-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/air... (diff) | |
| download | kernel-qcow2-linux-a414f01ac2899f273ef8fe98fa44158ac12793f2.tar.gz kernel-qcow2-linux-a414f01ac2899f273ef8fe98fa44158ac12793f2.tar.xz kernel-qcow2-linux-a414f01ac2899f273ef8fe98fa44158ac12793f2.zip | |
strcmp: fix overflow and possibly signedness error
Doing the strcmp return value as
signed char __res = *cs - *ct;
is wrong for two reasons. The subtraction can overflow because __res
doesn't use a type big enough. Moreover the compared bytes should be
interpreted as unsigned char as specified by POSIX.
The same problem is fixed in strncmp.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Michael Buesch <mb@bu3sch.de>
Cc: Andreas Schwab <schwab@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/net/ixgbe/ixgbe_ethtool.c')
0 files changed, 0 insertions, 0 deletions