summaryrefslogtreecommitdiffstats
path: root/drivers/net/phy/phy_device.c
diff options
context:
space:
mode:
authorHeiner Kallweit2019-01-23 07:27:21 +0100
committerDavid S. Miller2019-01-25 07:15:15 +0100
commita016becd3a56cdb260013c8fe1d4aefc6edc4989 (patch)
tree9e47392ab913ecf51d96fe9406994e3f2fc89c37 /drivers/net/phy/phy_device.c
parentnet: stmmac: Fix return value check in qcom_ethqos_probe() (diff)
downloadkernel-qcow2-linux-a016becd3a56cdb260013c8fe1d4aefc6edc4989.tar.gz
kernel-qcow2-linux-a016becd3a56cdb260013c8fe1d4aefc6edc4989.tar.xz
kernel-qcow2-linux-a016becd3a56cdb260013c8fe1d4aefc6edc4989.zip
net: phy: start state machine in phy_start only
The state machine is a no-op before phy_start() has been called. Therefore let's enable it in phy_start() only. In phy_start() let's call phy_start_machine() instead of phy_trigger_machine(). phy_start_machine is an alias for phy_trigger_machine but it makes clearer that we start the state machine here instead of just triggering a run. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/phy_device.c')
-rw-r--r--drivers/net/phy/phy_device.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 509d9402fa9a..64c25a0684ac 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -951,7 +951,6 @@ int phy_connect_direct(struct net_device *dev, struct phy_device *phydev,
return rc;
phy_prepare_link(phydev, handler);
- phy_start_machine(phydev);
if (phydev->irq > 0)
phy_start_interrupts(phydev);