diff options
| author | Mikhail Zolotaryov | 2009-03-19 23:28:02 +0100 |
|---|---|---|
| committer | David S. Miller | 2009-03-22 00:50:20 +0100 |
| commit | 62f0c338d126fee75dc04bd23be30281a0e1e62f (patch) | |
| tree | bbb314e4e9a107dfc3e2172970e4fdd29b9a1015 /drivers/net/spider_net.c | |
| parent | net: remove useless prefetch() call (diff) | |
| download | kernel-qcow2-linux-62f0c338d126fee75dc04bd23be30281a0e1e62f.tar.gz kernel-qcow2-linux-62f0c338d126fee75dc04bd23be30281a0e1e62f.tar.xz kernel-qcow2-linux-62f0c338d126fee75dc04bd23be30281a0e1e62f.zip | |
powerpc 4xx EMAC driver: device name reported on timeout is not correct
Hi,
IBM EMAC driver performs device reset (drivers/net/ibm_newemac/core.c:
emac_probe() -> emac_init_phy() -> emac_reset()) before registering
appropriate net_device (emac_probe() -> register_netdev()), so
net_device name contains raw format string during EMAC reset ("eth%d").
If the case of reset timeout, emac_report_timeout_error() function is
called to report an error. The problem is this function uses net_device
name to report device related, which is not correct, as a result in the
kernel log buffer we see:
eth%d: reset timeout
The solution is to print device_node full_name instead. After applying
the patch proposed, error string is like the following:
/plb/opb/ethernet@ef600e00: reset timeout
Signed-off-by: Mikhail Zolotaryov <lebon@lebon.org.ua>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/spider_net.c')
0 files changed, 0 insertions, 0 deletions