diff options
| author | Axel Lin | 2010-11-09 09:41:48 +0100 |
|---|---|---|
| committer | Guenter Roeck | 2010-11-11 18:43:51 +0100 |
| commit | 4f5b7994f0610fefff0782227ab71469ece54a5b (patch) | |
| tree | 15469190314d8eabd4d15370d57222348f896c74 /drivers/net/starfire.c | |
| parent | hwmon: (ad7414) Return proper error code for ad7414_probe() (diff) | |
| download | kernel-qcow2-linux-4f5b7994f0610fefff0782227ab71469ece54a5b.tar.gz kernel-qcow2-linux-4f5b7994f0610fefff0782227ab71469ece54a5b.tar.xz kernel-qcow2-linux-4f5b7994f0610fefff0782227ab71469ece54a5b.zip | |
hwmon: (gpio-fan) Fix fan_ctrl_init error path
In current implementation, the sysfs entries is not removed before return -ENODEV.
Creating the sysfs attribute should be the last thing done by the function,
after all the rest has been successful.
Otherwise there is a small window during which user-space can access the attribute
but the driver isn't ready to deal with the requests.
Fix it by moving sysfs_create_group to be the last thing done by the function.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Simon Guinot <sguinot@lacie.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Diffstat (limited to 'drivers/net/starfire.c')
0 files changed, 0 insertions, 0 deletions